Skip to content

adds patch_fee_cents_usd field #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 6, 2020
Merged

adds patch_fee_cents_usd field #14

merged 18 commits into from
Oct 6, 2020

Conversation

thdaraujo
Copy link
Contributor

@thdaraujo thdaraujo commented Sep 24, 2020 •
edited
Loading

[related to patch-180]

What

  • adds patch_fee_cents_usd field to orders
  • adds a build makefile to make it easier to lint and build the sdk code
  • standardize env variable name to SANDBOX_API_KEY

Why

  • to allow integrators to pass the patch fee to their users

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the gem locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@thdaraujo thdaraujo changed the title adds patch_fee + change price_cents_usd type from string to integer adds patch_fee_cents_usd field + change price_cents_usd type from string to integer Sep 24, 2020
@thdaraujo thdaraujo self-assigned this Sep 24, 2020
@thdaraujo thdaraujo marked this pull request as ready for review September 24, 2020 23:46
@thdaraujo thdaraujo added the Needs Review The PR is ready to be reviewed label Sep 24, 2020
@thdaraujo thdaraujo requested a review from biglovisa September 25, 2020 18:45
biglovisa
biglovisa approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@biglovisa biglovisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤙

.github/PULL_REQUEST_TEMPLATE.md
@@ -10,3 +10,6 @@

- [ ] Have you added an integration test for the changes?
- [ ] Have you built the gem locally and made queries against it successfully?
- [ ] Did you update the changelog?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@thdaraujo thdaraujo removed the Needs Review The PR is ready to be reviewed label Sep 26, 2020
@thdaraujo thdaraujo changed the title adds patch_fee_cents_usd field + change price_cents_usd type from string to integer adds patch_fee_cents_usd field Sep 29, 2020
@thdaraujo thdaraujo added the Needs Review The PR is ready to be reviewed label Sep 29, 2020
@biglovisa biglovisa added Reviewed This PR has been reviewed, but still needs some changes. and removed Needs Review The PR is ready to be reviewed labels Sep 30, 2020
@biglovisa
Copy link
Contributor

LGTM! 👍

@thdaraujo thdaraujo added Ready This PR is ready to ship! Don't Merge This PR is unsafe. Do not merge it. and removed Reviewed This PR has been reviewed, but still needs some changes. labels Sep 30, 2020
@thdaraujo thdaraujo removed the Don't Merge This PR is unsafe. Do not merge it. label Oct 5, 2020
biglovisa
biglovisa reviewed Oct 5, 2020
View reviewed changes
spec/integration/orders_spec.rb Outdated
retrieve_projects_response = Patch::Project.retrieve_projects(page: 1)
project_id = retrieve_projects_response.data.first.id
# biomass project
retrieve_project_response = Patch::Project.retrieve_project("pro_test_c3a9feba769fc7a8806377266ca9ff6a")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we want to keep this id in a shared location so we can reuse it in other specs?

biglovisa
biglovisa reviewed Oct 6, 2020
View reviewed changes
spec/constants.rb
@@ -0,0 +1,3 @@
module Constants
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@thdaraujo thdaraujo merged commit 1b05bc9 into main Oct 6, 2020
@thdaraujo thdaraujo deleted the ta/patch-fee-and-price-type-change branch October 13, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@biglovisa biglovisa biglovisa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@thdaraujo thdaraujo

Labels
Ready This PR is ready to ship!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thdaraujo @biglovisa